This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Display clients count in monocle symbol Fix #387 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yveszoundi
commented
Feb 21, 2023
yveszoundi
commented
- Replicate missing functionality from dwl to display the client count in monocle mode
- Add ltsymbol field to Monitor struct
- Display client count in monocle mode when greater than zero
- Tested with somebar and dwlb
|
This addresses issue #387 |
|
Please let me know if there are any concerns. In case it helps, I added few screenshots with most of the supported status bars. Notes
Screenshotssomebar
dwlb
yambar (latest git)
waybar
|
|
A little unrelated and I don't mean to hijack. I'm sorry dwl-bar didn't work, I already had a commit made, but forgot to push it up. Everything should work now. I tested and got a screenshot of dwl-bar working with your pr; I can't wait for this pr to be merged!
|
sevz17
force-pushed
the
feature/387-monocle-client-count
branch
from
63b290a to
35e9611
Compare
- Replicate missing functionality from dwl to display the client count in monocle mode - Add ltsymbol field to Monitor struct - Display client count in monocle mode when greater than zero - Tested with somebar and dwlb
sevz17
force-pushed
the
feature/387-monocle-client-count
branch
from
35e9611 to
bbdf2a9
Compare
|
Thanks! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.