Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Draw fullscreen_bg on the correct layer #488

Closed
wants to merge 3 commits into from
Closed

Draw fullscreen_bg on the correct layer #488

wants to merge 3 commits into from

Conversation

fbushstone
Copy link
Contributor

@fbushstone fbushstone commented Sep 25, 2023

Closes Issue 487.
dwl would draw the background on the wrong layer, obscuring SDL apps such as Quake and making certain terminals totally transparent except for the text (adjusting alpha on fullscreen_bg would not have helped in this case).

@sevz17
Copy link
Collaborator

sevz17 commented Sep 25, 2023

Hm
I don't think this will work, this could render the background behind the wallpaper (I didn't test).
And I think it's better to avoid fullscreen windows being in other layer than LyrFS and make sure that fullscreen_bg is always at the bottom of LyrFS

@fbushstone
Copy link
Contributor Author

fbushstone commented Sep 25, 2023

On second inspection, I shouldn't have pushed that change. It seems like certain clients request fullscreen mode, are actually fullscreen, but then dwl doesn't consider them fullscreen internally for whatever reason. Toggling fullscreen twice seems to get around this for now.

@fbushstone
Copy link
Contributor Author

Poor solution on my part, see my updated pull request

@fbushstone fbushstone closed this Sep 29, 2023
@fbushstone fbushstone deleted the fullscreen_bg-correct-pos branch September 29, 2023 18:51
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that background does not spawn in front of fullscreen clients
2 participants