Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix equality #61

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Fix equality #61

merged 2 commits into from
Jan 23, 2023

Conversation

djs55
Copy link
Owner

@djs55 djs55 commented Jan 23, 2023

When returning an OCaml value we need to construct a value with a Val_ macro. Bool_val is for extracting an OCaml bool value to C.

Also make a trivial build fix for OCaml 4.02 for max compat.

Signed-off-by: David Scott dave@recoil.org

When returning an OCaml value we need to construct a value with a Val_
macro. Bool_val is for extracting an OCaml bool value to C.

Signed-off-by: David Scott <dave@recoil.org>
@djs55 djs55 mentioned this pull request Jan 23, 2023
Signed-off-by: David Scott <dave@recoil.org>
@djs55 djs55 merged commit eea2999 into master Jan 23, 2023
@djs55 djs55 deleted the fix-bool branch January 23, 2023 20:49
djs55 added a commit to djs55/opam-repository that referenced this pull request Jan 23, 2023
CHANGES:

- Fix build on OCaml 4.02 and fix SHA equality bug by @djs55 (djs55/ocaml-sha#61)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant