Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move expression.BinExp.checkOpAssignTypes to expressionsem #15755

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

RazvanN7
Copy link
Contributor

There is no point in having checkOpAssignTypes in expression.d:

  • it requires semantic information (such as types already being present and performs casts that require semantic analysis)
  • it is called only once from expressionsem.d, as such it can be made private
  • once Get rid of extra indirection for implictCastTo and castTo for expressions #15754 is merged and this is merged, there is only one function that needs to be moved to break the dependency of expression.d on dcast.d

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15755"

@dlang-bot dlang-bot merged commit 0ea8c4c into dlang:master Oct 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants