Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GHA: Bump macOS images to 13 and 14 #17035

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Oct 28, 2024

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17035"

@kinke
Copy link
Contributor Author

kinke commented Oct 28, 2024

The macos-14 GHA runners are ARM64 ones, so using Rosetta emulation all the way. And that seems to be uber-slow for the DMD testsuite (maybe because spawning a lot of compile & link processes?).

It might be worth a try to use an LDC host compiler for that job, and building/using an ARM64 DMD (which obviously still generates x86_64 code). Edit: Oh, no dmd.root.longdouble.longdouble_soft support when building DMD for a non-x86 architecture.

@kinke kinke force-pushed the gha_bump_macos branch 3 times, most recently from c368a6c to e7b262e Compare October 29, 2024 22:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants