Adds resource field reference syntax to template strings #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
burnash
force-pushed
the
feat/2190-simplify-dependent-resource-declaration
branch
from
40d5201 to
5c1e6b2
Compare
burnash
force-pushed
the
feat/2190-simplify-dependent-resource-declaration
branch
from
5c1e6b2 to
6ac4fdc
Compare
rudolfix
requested changes
Feb 3, 2025
There was a problem hiding this comment.
I have some comments to the code. Tests look good though. What is still missing:
- examples (github/demo pipeline - incremental) not converted to a new notation
- I do not see tests that use invalid placeholders
- {unknown.attr}
- {incremental.unknown}
- a test where we define several parent resources ie. {resources.issue.id} and {resources.posts.id} in the same resource. I think that there's universal check for those but it makes sense to check it
| if isinstance(obj, str): | ||
| return obj.format(**placeholders) | ||
|
|
||
| if isinstance(obj, dict): |
There was a problem hiding this comment.
you could replace recursive code with utils.map_nested_in_place and just provide lambda obj: obj.format() as mapping function
There was a problem hiding this comment.
I prefer keeping the non-mutating way here rather than changing the dict in place.
- Add support for interpolating in query and json parameters - Stricter validation for resource params - Refactor path and parameter binding - Error handling for invalid resource params
- Generalize context validation for path and parameter interpolation - Add parameterized test for incorrect interpolation scenarios
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2190
Implements #1880 by introducing
incrementalcontext object.