Replace EXTRA_CFLAGS with ccflags-y #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
public testing running
public testing failed
and removed
untested
public testing running
labels
sweettea
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Some of these changes may not be strictly necessary, but it's probably better to change everything rather than try to sort out exactly which ones care about this change and which don't.
Also, what happened with the CI tests? They show a failure but I can't figure out what that failure is.
One question is when did the deprecation/changeover happen? Would it make sense for us to backport this to older versions? (I think probably not, there's no reason for the kernel to backport this kind of build change.)
sweettea
approved these changes
Mar 4, 2025
sweettea
suggested changes
Mar 4, 2025
C2Redhat
changed the title
Based on: https://www.kernel.org/doc/Documentation/kbuild/makefiles.txt EXTRA_CFLAGS has been deprecated. We should be using ccflags-y. Replaced EXTRA_CFLAGS with ccflags-y in all our files.
lorelei-sakai
approved these changes
Mar 5, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
https://www.kernel.org/doc/Documentation/kbuild/makefiles.txt
EXTRA_FLAGS has been deprecated. We should be using ccflags-y. Replaced EXTRA_CFLAGS with ccflags-y in all our files.