Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle deleted nodes in XGBoost #564

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 24, 2024

Closes #561

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (26103a5) to head (076391b).
Report is 11 commits behind head on mainline.

Files Patch % Lines
src/model_builder/model_builder.cc 85.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline     #564      +/-   ##
============================================
- Coverage     84.66%   84.57%   -0.09%     
============================================
  Files            71       71              
  Lines          6330     6340      +10     
  Branches        521      523       +2     
============================================
+ Hits           5359     5362       +3     
- Misses          971      978       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcho3 hcho3 merged commit 91778fe into dmlc:mainline May 24, 2024
18 of 19 checks passed
@hcho3 hcho3 deleted the deleted_xgb_node branch May 29, 2024 01:56
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jun 15, 2024
Treelite 4.2.1 contains the following improvements:

* Compatibility patch for latest RapidJSON (dmlc/treelite#567)
* Support for NumPy 2.0 (dmlc/treelite#562). Thanks @jameslamb
* Handle certain class of XGBoost models (dmlc/treelite#564)

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Ray Douglass (https://github.com/raydouglass)
  - James Lamb (https://github.com/jameslamb)

URL: #5908
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xgboost json model fails to load
1 participant