Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use latest pylint + Remove outdated docstring #586

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Sep 27, 2024

  • Reduce positional arguments to 4 per function.
  • Show a deprecation notice whenever the user uses a public function with too many positional arguments.
  • Treelite now supports HistGradientBoostingRegressor with categorical features. Remove an outdated docstring.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.80%. Comparing base (bf9c75a) to head (55559f2).
Report is 8 commits behind head on mainline.

Files with missing lines Patch % Lines
python/treelite/util.py 81.25% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline     #586      +/-   ##
============================================
- Coverage     84.82%   84.80%   -0.02%     
============================================
  Files            75       75              
  Lines          6549     6587      +38     
  Branches        528      528              
============================================
+ Hits           5555     5586      +31     
- Misses          994     1001       +7     
Flag Coverage Δ
84.80% <84.61%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcho3 hcho3 merged commit 386f50c into dmlc:mainline Sep 28, 2024
17 of 20 checks passed
@hcho3 hcho3 deleted the fix_docstring branch September 28, 2024 00:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant