More flexible workspace detection #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a4cd5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
maintainer
✅ Deploy Preview for #-api canceled.
|
✅ Deploy Preview for dmno ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
theoephraim
commented
Aug 14, 2024
| @@ -0,0 +1,3 @@ | |||
| projects: | |||
There was a problem hiding this comment.
not sure about this name...
- "packages" feels a bit too javascript-y
- "services" is our current nomenclature, although technically here we are saying where folders are that might be dmno services, they still need a
.dmnofolder to be considered a dmno service - "workspaces" (npm, bun) is just confusing
- "projects" (moonrepo) feels fairly reasonable in a polyglot world
We could replace the term "service" with "project" everywhere?
theoephraim
commented
Aug 14, 2024
| @@ -0,0 +1,3 @@ | |||
| projects: | |||
There was a problem hiding this comment.
Note that our example repo now needs this file, since otherwise we keep scanning upwards and find the root pnpm-workspace.yaml file. While I hadn't planned on that, it makes sense and is more explicit.
theoephraim
force-pushed
the
workspace-detection
branch
from
14e0ac6 to
52dd230
Compare
theoephraim
force-pushed
the
workspace-detection
branch
from
52dd230 to
617be9f
Compare
|
commit: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we relied completely on (js) package managers to get the workspace package/project globs, for example
pnpm-workspace.yaml(pnpm) or theworkspaceskey inpackage.jsonfiles (npm, yarn, bun).This creates problems in a monorepo that is not only using one of these package manager or using it to manage the monorepo. For example, one can imagine a monorepo that has several child "monorepos" managed by pnpm within it, or a polyglot case where there is no central package manager handling everything.
Now instead we will walk up from the current directory to the git root (if applicable), and if we ever find a
.dmno/dmno-workspace.yamlfile, it will be considered the root and override everything else. Otherwise we'll rely on the js package managers, or fallback to the git root if nothing else is found.