Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Disable loadtest on test/temp rses #646

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

guyzsarun
Copy link
Contributor

Fix: #639

Update loadtest from SITECONF storage.json on rse cms_type: real only

@dynamic-entropy
Copy link
Contributor

Hello!
Yes, I noticed this, from rule approved messages. However, is it not good to have the loadtests on the test rses?
For temp, I agree.

@dynamic-entropy dynamic-entropy merged commit 1415c95 into dmwm:master Nov 7, 2023
@dynamic-entropy
Copy link
Contributor

Thankyou so much for the PR though.

@guyzsarun
Copy link
Contributor Author

it is crashing the loadtest service.
From my understanding, the test rse also points to the same endpoint as the original just on different path?

Hello! Yes, I noticed this, from rule approved messages. However, is it not good to have the loadtests on the test rses? For temp, I agree.

@dynamic-entropy
Copy link
Contributor

Ok, thankyou.

@guyzsarun
Copy link
Contributor Author

@dynamic-entropy I disabled loadtest on all temp rse, please let me know your suggestion for the test rse

@dynamic-entropy
Copy link
Contributor

We can let it be as is for now. (I don't want to touch loadtests, until someone takes to refactoring and documentung it all).

@dynamic-entropy
Copy link
Contributor

I deleted the ones for test (and temp) rses too actually. When I merged this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants