Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #8809 #8884

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Fix #8809 #8884

merged 8 commits into from
Jan 20, 2025

Conversation

aspiringmind-code
Copy link
Contributor

See #8809

  • Remove CHECK_TEST_RESULT variable to make it easier to understand and streamlining
  • Make the pipeline more robust using rules like skip_check and skip_submit
  • Now we only need to set three variables: SUBMIT_STATUS_TRACKING, CLIENT_CONFIGURATION_VALIDATION and CLIENT_VALIDATION_SUITE for both task submission and checking of their respective actions. By default, they are all set to true.
  • We additionally have three skip variables SKIP_BUILD, SKIP_DEPLOY and SKIP_SUBMIT which can be used if so desired. By default they are all set to false.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2321/artifact/artifacts/PullRequestReport.html

@belforte
Copy link
Member

Now we only need to set three variables: SUBMIT_STATUS_TRACKING, CLIENT_CONFIGURATION_VALIDATION and CLIENT_VALIDATION_SUIT

should SUBMIT_ be removed from the name of the first variable then, for consistency ? Same for _SUIT in the last.

@belforte
Copy link
Member

thanks Vijay, I agree with plan in the top bullet list, but am not able to relate it to the code. Can we have a sort of walk-through ?

@aspiringmind-code
Copy link
Contributor Author

Yes, sure

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2322/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@sinonkt sinonkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looks good to me! Thanks!

Copy link
Member

@belforte belforte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

@aspiringmind-code aspiringmind-code merged commit bd7348c into dmwm:master Jan 20, 2025
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants