Fix for issue #20 correcting empty-context add-only patches #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty-context add-only patches were applied in the wrong place, typically one line early. This commit uses the code submitted in the issue but tidied up and corrected for current master snapshot.
Bad copy&paste caused use of InsertDelta instead of DeleteDelta when applying fix for issue #20. Also improved test to cover empty-context patches that delete lines to cover this case.
DiffUtils.generateUnifiedDiff() produced off-by-one positions for hunks with empty context/content. EmptyContextUnifiedDiffTest.java has been improved to test for this. (Some test resource files renamed in light of more general use).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty-context add-only patches were applied in the wrong place,
typically one line early.
This commit uses the code submitted in the issue but tidied up
and corrected for current master snapshot.