[#119] feat: 프로필 수정 화면 구현 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for gongmuin failed. Why did it fail? →
|
SujinKim1127
requested review from
seokzin,
dohui-son,
jhsung23,
azure-553,
jiji-hoon96 and
Zero-1016
Closed
Zero-1016
reviewed
Sep 24, 2024
|
|
||
| return ( | ||
| <div> | ||
| <div style={{ marginBottom: '36px' }}> |
There was a problem hiding this comment.
필요한 스타일 요소가 1개밖에 없어서 이렇게 작성을 했는데 style.css.ts에서 컴포넌트 선언하는게 더 좋을까요?
꼭 컴포넌트 선언을 해야할까? 라고 생각하면서 코드 작성했습니다
어떤게 더 좋을까요?
일관성 있게 컴포넌트 선언을 할까요?
There was a problem hiding this comment.
다른 스타일의 경우 필요한 스타일이 하나만 있을때도 분리를 하셨기에 드린 질문이었습니다!
| return ( | ||
| <div className={pageContainer}> | ||
| <ProfileUpdateInputSection form={updateForm} /> | ||
| <div className={marginBox}> |
There was a problem hiding this comment.
div 태그를 설정하지 않고 Button 태그내에 스타일을 전달해주는건 어떨까요? 불필요한 태그가 생기지 않아도 될 것 같습니다.
There was a problem hiding this comment.
급한거 먼저 하느라 답변이 늦었네요 ㅠㅠ
혹시 불필요하다고 느끼신 이유가 있으신가요??
저는 컴포넌트를 항상 div로 감싸서 위치 코드를 div에 작성해서요!
그래야 뭔가 Button은 Button만의 스타일을 가지는 느낌이 들더라구요
|
|
||
| export const useProfileUpdateForm = | ||
| (): UseFormReturn<ProfileUpdateFormValues> => { | ||
| const form = useForm({ |
There was a problem hiding this comment.
아래처럼 바꾼다면 타입 단언을 사용하지 않아도 되지 않을까 싶습니다!
Suggested change
| const form = useForm({ | |
| return useForm<ProfileUpdateFormValues>({ |
Deploying gongmuin with
|
| Latest commit: |
3a8c7b4
|
| Status: | 🚫 Build failed. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Main Topic of feature / bug
LabeledInputWithButton컴포넌트 사용을 위해 중복확인 api만 연결했습니다🧩 Description
🛠️ Related Issue or References
💡 Test Done & How to Test
📌 Checklist
⏰ TODOS