Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Contribution file needs to be updated to document new commit standard #2044

Closed
SkyeHoefling opened this issue May 1, 2018 · 1 comment
Closed

Contribution file needs to be updated to document new commit standard #2044

SkyeHoefling opened this issue May 1, 2018 · 1 comment
Milestone
9.2.1

Comments

@SkyeHoefling
Copy link
Contributor

Since we have now transitioned to GitHub issues from Jira for tracking issues we need to update the contribution doc. It currently documents marking each commit with DNN-####. This should be updated to reference the new standard of using github # notation in commits
@ashishpd
Copy link
Contributor

ashishpd commented May 1, 2018

We should mention DNN-#### or the issue #. Can you please submit a PR @ahoefling

SkyeHoefling pushed a commit to SkyeHoefling/Dnn.Platform that referenced this issue May 1, 2018
dnnsoftware#2044 Updatec contributing guide for GitHub issues
da75d87
@SkyeHoefling SkyeHoefling mentioned this issue May 1, 2018
Merged
SkyeHoefling pushed a commit to SkyeHoefling/Dnn.Platform that referenced this issue May 1, 2018
dnnsoftware#2044 Updating contribution guide for pull requests to inc…
4aa5cb3 
…lude github issue ID
@ohine ohine added this to the 9.2.1 milestone May 26, 2018
@ohine ohine closed this as completed Jun 12, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.1
Development

No branches or pull requests
3 participants
@ashishpd @ohine @SkyeHoefling