Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sitegroups doesn't allow sharing modules #4023

Closed
8 tasks
jncraig opened this issue Aug 31, 2020 · 7 comments · Fixed by #4597
Closed
8 tasks

Sitegroups doesn't allow sharing modules #4023

jncraig opened this issue Aug 31, 2020 · 7 comments · Fixed by #4597

Comments

@jncraig
Copy link

jncraig commented Aug 31, 2020

Description of bug

The sitegroups functionality doesn't allow existing modules to be added from other sites. There is no dropdown in the Add Existing Module panel to select the site.

Steps to reproduce

  1. Create a sitegroup and add sites
  2. Go to a site
  3. In Edit Mode, click Add Existing Module
  4. There is no way to select a site and page from which to add a module. Only same site modules can be added

Current behavior

There is no way to select the site from which an existing module is to be added tot the current site.

Expected behavior

There should be a way to select the site and the page

Screenshots

If applicable, provide screenshots to help explain the bug.

Error information

It's really missing functionality rather than a bug.

Additional context

Provide any additional context that may be helpful in understanding and/or resolving the bug.

Affected version

  • 10.00.00 alpha build
  • [x ] 09.07.01 release candidate
  • 09.07.00 latest supported release

Also 9.6.1.

Affected browser

N/A

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 11
  • Microsoft Edge (Classic)
  • Microsoft Edge Chromium
@thabaum
Copy link
Contributor

thabaum commented Sep 8, 2020

is this a feature that should be discussed to be added?

@valadas
Copy link
Contributor

valadas commented Sep 9, 2020

Well IMO, this does not really need discussing, we just need to update the dropdown to be able to select modules from other portals in the group if the settings allow it...

@stale
Copy link

stale bot commented Dec 9, 2020

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Dec 9, 2020
@jncraig
Copy link
Author

jncraig commented Dec 18, 2020

Still is important to me!

@stale stale bot removed the stale label Dec 18, 2020
@david-poindexter david-poindexter added this to the Future: Minor milestone Feb 21, 2021
@david-poindexter
Copy link
Contributor

Upon a cursory check, this one is going to be JS world (not React). Here is the Existing Module Dialog code.
https://github.com/dnnsoftware/Dnn.Platform/blob/714db32390f800ea2336bb0fd2d54fc589256e6b/Dnn.AdminExperience/EditBar/Dnn.EditBar.UI/editBar/resources/ContentEditorManager/Js/ExistingModuleDialog.js

@jncraig I'll see if I can dig into this a bit more after DNN Summit. Right now is last-minute-scramble time! 😱

@jncraig
Copy link
Author

jncraig commented Feb 21, 2021 via email

@david-poindexter
Copy link
Contributor

Closing per PR #4597

# for free to join this conversation on GitHub. Already have an account? # to comment