Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Login/logout redirection tabs are defaulting to 0 instead of -1 #4260

Closed
11 of 12 tasks
daguiler opened this issue Oct 28, 2020 · 8 comments · Fixed by #4851
Closed
11 of 12 tasks

Login/logout redirection tabs are defaulting to 0 instead of -1 #4260

daguiler opened this issue Oct 28, 2020 · 8 comments · Fixed by #4851

Comments

@daguiler
Copy link
Contributor

Description of bug

After login/logout redirection settings were migrated to Site Settings (#3845), there is an issue when saving.
When other settings in the panel are changed but Redirect After Login/Logout are left untouched, their default values are set to 0, instead of -1. This causes DNN to navigate to tab ID 0 after logout, causing a 404:

http://platform-9-7-1.dnndev.me/tabid/0/Default.aspx

Notice the tabid/0 part of the URL.

Upon further investigation, I noticed that these values are null in the front-end, and converted to 0 in the back-end when cast to integers.

Steps to reproduce

  1. Clean DNN 9.7.0 or above
  2. Open SETTINGS > Site Settings > Site Behavior > DEFAULT PAGES
  3. Click on the User Profile Page dropdown (the dropdown expands and the Save button becomes enabled)
  4. Click Save
  5. Close the Persona Bar
  6. Log out

Current behavior

DNN redirects to /tabid/0/Default.aspx after logout, causing a 404.

Expected behavior

DNN should redirect to the home page.

Screenshots

image

Error information

N/A

Additional context

N/A

Affected version

  • 10.00.00 alpha build
  • 09.08.00 release candidate
  • 09.07.02 latest supported release
  • 09.07.01 latest supported release
  • 09.07.00 latest supported release
  • 09.06.02 latest supported release

Affected browser

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 11
  • Microsoft Edge (Classic)
  • Microsoft Edge Chromium
@tpperlman
Copy link

I can confirm this in v9.8. I had to change the redirect drop-downs to home and then back to to resolve.

@noahbast
Copy link

noahbast commented Jan 6, 2021

We had this happen today on a large ecommerce site running 9.8.0. It was a major issue with no clear cause. Switching redirects in site settings to home, saving, then switching back to none specified fixed it.

It was happening after login, logout, and registration.

@stale
Copy link

stale bot commented Jun 2, 2021

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Jun 2, 2021
@sleupold
Copy link
Contributor

sleupold commented Jun 2, 2021

@valadas has this been fixed meanwhile, do you know?

@valadas valadas removed the stale label Jun 3, 2021
@valadas
Copy link
Contributor

valadas commented Jun 3, 2021

I am really not sure, I know I have a strange issue after login/logout on a clean 9.9.1 site but did not have time to dig into the details yet.

@stale
Copy link

stale bot commented Sep 3, 2021

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Sep 3, 2021
@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been closed automatically due to inactivity (as mentioned 14 days ago). Feel free to re-open the issue if you believe it is still relevant.

@valadas
Copy link
Contributor

valadas commented Sep 22, 2021

I reopened this as I want to try to handle that for 9.10.2 time permitting

valadas added a commit to valadas/Dnn.Platform that referenced this issue Oct 3, 2021
…r localized sites.

The settings for the current portal alias local where returned to the UI instead of the requested language picked in the Page Settings editor. This caused an issue where you would get let's say the english tabs for a french site settings if the last page you happend to visit was english instead of french. The user would then save any setting and all the RedirectAfters would save the wrong thing for that locale.

Closes dnnsoftware#4232
Closes dnnsoftware#4260
bdukes pushed a commit that referenced this issue Oct 4, 2021
…r localized sites.

The settings for the current portal alias local where returned to the UI instead of the requested language picked in the Page Settings editor. This caused an issue where you would get let's say the english tabs for a french site settings if the last page you happend to visit was english instead of french. The user would then save any setting and all the RedirectAfters would save the wrong thing for that locale.

Closes #4232
Closes #4260
# for free to join this conversation on GitHub. Already have an account? # to comment