Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Enhancement]: Upgrade CodeDOM provider by default #5689

Closed
3 of 4 tasks
bdukes opened this issue Jun 15, 2023 · 2 comments
Closed
3 of 4 tasks

[Enhancement]: Upgrade CodeDOM provider by default #5689

bdukes opened this issue Jun 15, 2023 · 2 comments

Comments

@bdukes
Copy link
Contributor

bdukes commented Jun 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

The ASP.NET runtime compiler defaults to an older version of the C# and VB.NET compilers. DNN includes a package which updates the compilers, but it isn't installed by default.

Description of solution

Install the CodeDOM provider package by default on installs and upgrades.

Description of alternatives considered

Continue to provide it as an optional package.

Anything else?

With the provider installed, this Razor script renders correctly, <h1>@(Dnn?.ActiveModule?.ModuleID)</h1>, whereas it gives an error without the provider being installed (because the ?. operator was introduced in C# 6, and the ASP.NET compiler only supports C# 5 by default).

This package is currently optional because previous versions of DNN found examples of installations failing on GoDaddy hosting, since the package installs csc.exe and vbc.exe into the bin folder. Our expectation is that testing for DNN 10 will reveal any incompatibilities with currently used hosting providers.

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
bdukes added a commit to bdukes/Dnn.Platform that referenced this issue Jun 15, 2023
@jeremy-farrance
Copy link
Contributor

This is fantastic! I am strongly in favor of this and looking forward to no longer having to do this additional setup step after every DNN install. Cheers!!

@valadas
Copy link
Contributor

valadas commented Jun 15, 2023

Merged into v10 branch.

Yes, the few in odd hosting environments that can't allow this, users can just delete that zip or rename to .resoruces as a workaround...

The needs of the many outweigh the needs of the few....

@valadas valadas closed this as completed Jun 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants