[Bug]: CKE Provider host level settings not stored consistently

[skamphuis]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

I found that host level settings are not working correctly in the CKEditor Provider.

In short: the options form has code to save host level settings, geving the settingname a prefix of DNNCKH# (note the H for HOST level). However, the property that sets the SettingMode to host level, is never set correctly. As a consequence, host level settings are being saved with a prefix of DNNCKP#-1# (note the P for portal level and the -1 for portalId).

When rendering the editor, the host level settings are tried by using the key DNNCKH# which obviously doesn't exist.

Steps to reproduce?

The issue is hard to see, because of another issue where in the options page host level settings prevale over site level ones, but upon rendering, it's the other way around (I'll log another issue for that).

1. Open the html editor provider settings from Site Settings
2. Uncheck the checkbox "This site only" to enter host level settings
3. Change an obvious setting (e.g. "Editor Height")
4. Check the values in the database: SELECT * FROM CKE_Settings WHERE SettingName LIKE '%#height'
5. You will notice no setting starts with DNNCKH#

Current Behavior

For some settings, the host level settings do work, because the DNNCKP#-1# key is used to read them. But in other places it doesn't.

Expected Behavior

No response

Relevant log output

No response

Anything else?

I'm working on a PR already.

Affected Versions

9.12.0 (latest release)

What browsers are you seeing the problem on?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct