Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug]: Current develop branch has wrong version from GitVersion #5871

Closed
2 tasks done
valadas opened this issue Nov 18, 2023 · 0 comments · Fixed by #5872
Closed
2 tasks done

[Bug]: Current develop branch has wrong version from GitVersion #5871

valadas opened this issue Nov 18, 2023 · 0 comments · Fixed by #5872

Comments

@valadas
Copy link
Contributor

valadas commented Nov 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Building the current develop branch in CI has it versioned as v10.0.1 instead of v9.13.1
This makes it hard to quickly test before creating the release branch for the next RC

Steps to reproduce?

  1. Clone the current develop branch
  2. Make sure you do not hardcode a version in the localSettings.json file
  3. Build DNN

Current Behavior

The artifacts are versioned v10.0.1

Expected Behavior

Should be versioned v9.13.1

Relevant log output

No response

Anything else?

No response

Affected Versions

9.13.1 (alpha)

What browsers are you seeing the problem on?

Chrome

Code of Conduct

  • I agree to follow this project's Code of Conduct
valadas added a commit to valadas/Dnn.Platform that referenced this issue Nov 18, 2023
Closes dnnsoftware#5871

Also further limits how far back GitVersion looks at commits for versioning purposes which makes it way quicker to run.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant