Added lint task to all node projects #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `lint` task into all projects with autofix enabled. This will make it easier to auto-fix eslint warnings if we change the configs or while updating eslint dependency in batch using lerna or yarn workspaces. Unfortunatally (well fortunatelly) there was no autofixable warnings to resolve after this change which was my main goal with this PR, anyway, it's still good to have I believe for the future.
bdukes
approved these changes
Aug 9, 2021
|
With #4770 merged, I've rebased this PR |
mitchelsellers
approved these changes
Aug 13, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
linttask into all projects with autofix enabled. This will make it easier to auto-fix eslint warnings if we change the configs or while updating eslint dependency in batch using lerna or yarn workspaces. Unfortunately (well fortunately) there were no autofixable warnings to resolve after this change which was my main goal with this PR, anyway, it's still good to have I believe for the future.Also, this PR includes the commits in #4770 so if it is merged first, this becomes easier to review. If this one gets merged first than dependabot should close #4770 automatically too.