Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Marked nuget dependency from DotNetNuke.Web on Microsoft.AspNet.WebApi.Core #4815

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Sep 4, 2021

I am not 100% if what I am doing is correct, but when upgrading a module to depend on DNN 9.10.1, the build fails saying that DotNetNuke.Web uses System.Web.Http v5.2.7 but the project references v5.2.3. I usually just update the dependency manually, but though we could declare it so it updates it automatically.

I am no nuget expert, so not sure if this is the right way to do it, looking at the nuget experts (you know who you are) :P

Summary

…i.Core

I am not 100% if what I am doing is correct, but when upgrading a module to depend on DNN 9.10.1, the build fails saying that DotNetNuke.Web uses System.Web.Http v5.2.7 but the project references v5.2.3. I usually just update the dependency manually, but though we could declare it so it updates it automatically.

I am no nuget expert, so not sure if this is the right way to do it, looking at the nuget experts (you know who you are) :P
@valadas valadas added this to the 9.10.2 milestone Sep 4, 2021
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchelsellers mitchelsellers merged commit bf50bee into dnnsoftware:develop Sep 14, 2021
@valadas valadas deleted the web-527 branch April 14, 2022 21:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants