Fixed SEO tab not updating correctly after deleting a URL #4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
Dec 1, 2021
bdukes
approved these changes
Dec 1, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4924
Summary
The S.E.O. view doesn't update correctly after changing the state because all automatic URLs are returned by the backend with the same
idof -1. And thisidproperty is used as the React component key, which needs to be unique.This is a typical pitfall with React.
My fix consists of using the array index to generate a negative sequence so that the first automatic URL gets -1, the second -2 and so on.