Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/eventlog ip address with proxy #5091

Merged

Conversation

skamphuis
Copy link
Contributor

Closes #5073

Summary

Changed the places where DNN didn't determine IPAddress by using the UserRequestIPAddressController class yet, to use that.
I found these occurences in:

  • DNN Platform/Library/Common/Utilities/NetworkUtils.cs
  • DNN Platform/Library/Entities/Modules/UserModuleBase.cs
  • DNN Platform/Library/Entities/Urls/UrlRewriterUtils.cs
  • DNN Platform/Library/Services/Exceptions/SecurityException.cs

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I did know even know about that class!

@skamphuis
Copy link
Contributor Author

Nice one, I did know even know about that class!

tbh: me neither. Ran into the issue after putting a client behind Cloudflare and we got pointed out this issue. When trying to figure out how to fix that, I found that it was implemented already, for a large part.

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@skamphuis
Copy link
Contributor Author

Thanks for your improvements, @bdukes
I just committed it.

@valadas valadas added this to the 9.10.3 milestone Apr 28, 2022
@valadas valadas merged commit d9bc17f into dnnsoftware:develop Apr 28, 2022
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use original user's IPAddress in logging and IPFilter when behind (e.g.) Cloudflare
5 participants