Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use JSON.parse over eval where appropriate #5239

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Use JSON.parse over eval where appropriate #5239

merged 1 commit into from
Aug 24, 2022

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Aug 24, 2022

Replace unnecessary usages of eval when JSON.parse will do.

@bdukes bdukes added the javascript Pull requests that update Javascript code label Aug 24, 2022
@bdukes bdukes added this to the 9.10.3 milestone Aug 24, 2022
@bdukes bdukes requested a review from mitchelsellers August 24, 2022 13:35
valadas
valadas approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@valadas valadas merged commit d778663 into dnnsoftware:develop Aug 24, 2022
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
@bdukes bdukes deleted the remove-eval branch January 19, 2023 22:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@valadas valadas valadas approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code Type: Maintenance
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bdukes @mitchelsellers @valadas