5339 Handle upload for image smaller than configured resize dimensions #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please target our default |
bdukes
approved these changes
Oct 18, 2022
bdukes
force-pushed
the
feature/5339-CKE-Upload-image-smaller-than-upload-resize-dimensions
branch
from
9c8a3de to
6706d64
Compare
mitchelsellers
approved these changes
Nov 8, 2022
skamphuis
deleted the
feature/5339-CKE-Upload-image-smaller-than-upload-resize-dimensions
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5339
Summary
The code checked wether resize on upload dimensions are configured, then checked wether the image needs resizing, but fails to actually upload if the image doesn't need resising.
This PR fixes that.