Made search placeholder localizable #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modification of pages search place holder that can be read from language resource files.
mitchelsellers
requested changes
Nov 2, 2022
The element is already available in the language resource file |
valadas
approved these changes
Nov 3, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mitchelsellers
approved these changes
Nov 3, 2022
valadas
requested changes
Nov 4, 2022
Dnn.AdminExperience/ClientSide/Pages.Web/src/components/SearchPage/SearchPageInput.jsx
Outdated
Show resolved
Hide resolved
|
You just have to run ./build.ps1 and get the installer from the artifacts folder and install a site with it. I am pretty sure those quotes need to be removed or it will just literally show that text. |
|
@dnnsoftware/approvers Please do not merge this until we have at least on test report from someone |
|
The build is failing anyway. I am pretty sure those outer quotes need to be removed. |
|
There are |
Dnn.AdminExperience/ClientSide/Pages.Web/src/components/SearchPage/SearchPageInput.jsx
Outdated
Show resolved
Hide resolved
…Page/SearchPageInput.jsx
uzmannazari
commented
Nov 17, 2022
mitchelsellers
approved these changes
Dec 6, 2022
valadas
approved these changes
Dec 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modification of pages search place holder that can be read from language resource files.