Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix the library debug build to debug folder #5396

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix the library debug build to debug folder #5396

merged 1 commit into from
Nov 15, 2022

Conversation

donker
Copy link
Contributor

@donker donker commented Nov 13, 2022

Since the addition of library.build to the Library project, the old build logic with a copy to the debug folder is bypassed. This PR fixes that.

@donker donker added this to the 9.11.1 milestone Nov 13, 2022
@donker donker requested review from bdukes and valadas November 13, 2022 10:37
valadas
valadas approved these changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I have been wondering what was happening there

@valadas valadas merged commit 351defc into dnnsoftware:develop Nov 15, 2022
@donker donker deleted the fixlibbld branch November 15, 2022 22:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@valadas valadas valadas approved these changes

@bdukes bdukes bdukes approved these changes

Assignees
No one assigned
Labels
Type: Bug Type: Build/Release Type: Maintenance
Projects
None yet
Milestone
9.11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@donker @bdukes @valadas