Possibly fixed intermittent build issues #5421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was consistently experiencing locally the build issues we sometimes (well oftentimes) get on azure (can't resolved Dnn.Platform\Dnn.AdminExperience\Dnn.PersonaBar.Extensions\Dnn.PersonaBar.Extensions.csproj)... So I was trying to pinpoint the possible cause of that issues and when I removed the Project GUIDS from this project file, the build started working. Many of the other .csproj files don't have any ProjectType defined at all and they work fine. I have confirmed that the install files are still being produced. One of the GUIDs defines this as an MVC project but it is clearly not, the other defines it as a C# project but the .csproj extension already defines that. Is anyone is opposed to remove both, then I can bring back the one starting with FAE04.... I am absolutelly not sure this will fix the intermittent build issues, because of them beeing intermittent but if it works, we may have fixed it...
mitchelsellers
approved these changes
Dec 5, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was consistently experiencing locally the build issues we sometimes (well oftentimes) get on azure (can't resolved Dnn.Platform\Dnn.AdminExperience\Dnn.PersonaBar.Extensions\Dnn.PersonaBar.Extensions.csproj)...
So I was trying to pinpoint the possible cause of that issues and when I removed the Project GUIDS from this project file, the build started working. Many of the other .csproj files don't have any ProjectType defined at all and they work fine.
I have confirmed that the install files are still being produced.
One of the GUIDs defines this as an MVC project but it is clearly not, the other defines it as a C# project but the .csproj extension already defines that.
Is anyone is opposed to remove both, then I can bring back the one starting with FAE04....
I am absolutelly not sure this will fix the intermittent build issues, because of them beeing intermittent but if it works, we may have fixed it...