Bumped Moq to v4.18.4 #5498
Merged
Bumped Moq to v4.18.4 #5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This properly bumps Moq to v4.18.4. Also fixes multiple unit tests due to this change or other reasons. One of the main reasons was that there was multiple tests that only tested a method was calling another overload of the same class. This was a very poor test to begin with and it looks like the new Moq did not like that anyway. I adjusted those tests so they actually test the effects of calling such method. I believe there might still be one test failing but I am too tired right now to handle that one. I am sending this PR to test how CI likes it, but please don't merge it until all the tests pass (well the ones we run anyway)...
|
Oh well, they all passed. Good for review then :) |
bdukes
approved these changes
Jan 19, 2023
mitchelsellers
approved these changes
Jan 24, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #5497
This properly bumps Moq to v4.18.4.
Also fixes multiple unit tests due to this change or other reasons. One of the main reasons was that there was multiple tests that only tested a method was calling another overload of the same class. This was a very poor test to begin with and it looks like the new Moq did not like that anyway. I adjusted those tests so they actually test the effects of calling such method.
I believe there might still be one test failing but I am too tired right now to handle that one. I am sending this PR to test how CI likes it, but please don't merge it until all the tests pass (well the ones we run anyway)...