-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added a new Google Analytics 4
Connector
#5666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google Analytics 4
Connector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
Google Analytics 4
ConnectorGoogle Analytics 4
Connector
@dnnsoftware/approvers should we remove the old GA connector? There's no reason to include it in new installs anymore, right? |
@bdukes for a clean installation, you are most likely correct |
Makes sense to me, upgrades would keep and people can uninstall it when not needed anymore. But... The module (UI) is only part of it, the actual engine is solely driven by the config file. Sooo, people would have to disconnect, then uninstall. One of the things I wanted to do (when I have some time) is to be able to call something like IUpgradeable but for uninstallation of a module. Basically define a method that gets called before the rest of the normal uninstall happens. That could be a nice solution for this but I won't have enough time to do it in v9... Maybe v10... |
In principle, I agree. In practice, there are some details about the base engine implementation that will require some thought as to how to unravel it all. For instance, it depends on the default |
Summary
Resolves #5665