Fixed an issue with the connectors checkboxes not saving properly #5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
Jun 12, 2023
david-poindexter
approved these changes
Jun 12, 2023
|
Thanks @bdukes this got us scratching our heads a bit :) |
valadas
changed the title
9 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5667
It appears the
checkedbinding started returningundefinedwhen unchecked (probably only alongside using thecheckedValuebinding) when we upgraded Knockout from 3.3.0 to 3.5.1.I'm now using
checkedValue: 'true'to set the value to a string when checked, and then falling back to the string'false'if it's not'true'.Thanks @david-poindexter and @valadas for pointing in the right direction.