-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Do all non-major npm upgrades #5764
Do all non-major npm upgrades #5764
Conversation
@valadas @david-poindexter Any idea why this TS error from the Resource Manager build might have happened after upgrading @stencil/core from 2.18.0 to 2.22.3?
|
@bdukes potentially because of the typescript version. More details here: https://stenciljs.com/docs/support-policy Now we should bump it to at least the v3, I have done so on about 20 other projects without too much trouble, we just need to also bump some plugins at the same time and take a look for any deprecated feature used in the stencil config file. I'll try to do that this weekend 🤞 |
I reverted @types/ws from 8.5.5 to 8.5.4 based on https://stackoverflow.com/a/76570993/2688, and that resolved the build for me locally. |
I believe this fix to the prop-types rule created new issues to resolve: jsx-eslint/eslint-plugin-react#442
Once that was resolved, there were eslint errors around undeclated prop-types. These appear to be real issues due to a bug in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I downloaded the CI build and can confirm everything appears to be working fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.