Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do all non-major npm upgrades #5764

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jul 25, 2023

No description provided.

@bdukes bdukes added Type: Maintenance javascript Pull requests that update Javascript code labels Jul 25, 2023
@bdukes bdukes added this to the 9.12.1 milestone Jul 25, 2023
@bdukes
Copy link
Contributor Author

bdukes commented Jul 25, 2023

@valadas @david-poindexter Any idea why this TS error from the Resource Manager build might have happened after upgrading @stencil/core from 2.18.0 to 2.22.3?

dnn-resource-manager: [30:42.6]  @stencil/core
dnn-resource-manager: [30:43.1]  v2.22.3
dnn-resource-manager: [30:47.4]  build, dnn-resource-manager, prod mode, started ...
dnn-resource-manager: [30:47.7]  transpile started ...
dnn-resource-manager: [31:00.3]  transpile finished in 12.59 s
dnn-resource-manager: [ ERROR ]  TypeScript: ../../../../node_modules/@types/ws/index.d.ts:328:18
dnn-resource-manager:            Type 'Server' is not generic.
dnn-resource-manager:     L327:  backlog?: number | undefined;
dnn-resource-manager:     L328:  server?: HTTPServer<V> | HTTPSServer<V> | undefined;
dnn-resource-manager:     L329:  verifyClient?:
dnn-resource-manager: [31:00.3]  build failed in 12.86 s

@valadas
Copy link
Contributor

valadas commented Jul 26, 2023

@bdukes potentially because of the typescript version. More details here: https://stenciljs.com/docs/support-policy

Now we should bump it to at least the v3, I have done so on about 20 other projects without too much trouble, we just need to also bump some plugins at the same time and take a look for any deprecated feature used in the stencil config file. I'll try to do that this weekend 🤞

@bdukes
Copy link
Contributor Author

bdukes commented Jul 26, 2023

I reverted @types/ws from 8.5.5 to 8.5.4 based on https://stackoverflow.com/a/76570993/2688, and that resolved the build for me locally.

bdukes added 2 commits July 26, 2023 12:49
I believe this fix to the prop-types rule created new issues to resolve:
jsx-eslint/eslint-plugin-react#442
@bdukes
Copy link
Contributor Author

bdukes commented Jul 26, 2023

Once that was resolved, there were eslint errors around undeclated prop-types. These appear to be real issues due to a bug in the prop-types rule. For now, I reverted to an older version of eslint-plugin-react and fixed the two issues that came up when on that version. It's now all successfully building (for me, locally 🤞🏻)

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I downloaded the CI build and can confirm everything appears to be working fine.

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-poindexter david-poindexter merged commit 30d7c7c into dnnsoftware:develop Jul 28, 2023
@david-poindexter david-poindexter deleted the update-yarn-dependencies branch July 28, 2023 01:37
@valadas valadas modified the milestones: 9.12.1, 9.13.0 Aug 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
javascript Pull requests that update Javascript code Type: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants