Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update web.config max upload size defaults, correct backend calcs, and fix validation issue preventing increasing #5807

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

david-poindexter
Copy link
Contributor

Summary

Resolves #5778

The following was done in this PR:

  • Updated default values for maxRequestLength in development.config and release.config.
  • Added section for IIS7 support of maxAllowedContentLength
<system.webServer>
    <security>
      <requestFiltering>
        <requestLimits maxAllowedContentLength="28672000" />
      </requestFiltering>
    </security>
</system.webServer>
  • Resolved backend calculation issues resulting in confusing values (by default and when saving)
  • Resolved validation issue that was preventing an admin from increasing the Max Upload Size in the UI. Now it validates against the max supported value of 4GB (minus one byte) for IIS.

Lastly, we decided it best to not add a new field in the UI to control requestLengthDiskThreshold. Since this is not something DNN admins would typically know/understand, it is best to leave this to manual web.config changes by server admins wanting to optimize performance for specific scenarios/environments.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just one value is not the "Microsoft default" and is quite big here

DNN Platform/Tests/App.config Show resolved Hide resolved
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@valadas valadas merged commit 7c9c29f into dnnsoftware:develop Sep 8, 2023
@david-poindexter david-poindexter deleted the issue-5778 branch September 8, 2023 21:27
# for free to join this conversation on GitHub. Already have an account? # to comment