Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Completely remove the ability to edit another user from control. #5971

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

donker
Copy link
Contributor

@donker donker commented Feb 15, 2024

Summary

The EditUser control used to be used to edit users in a (now defunct) module in DNN pre PersonaBar. Currently it is only used to edit one's details when you click on Edit on your profile page. It no longer needs the ability to edit another user and this should be disabled.

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not have time to test this yet, but it looks good from a browser review perspective. I will not merge it to allow for testing if others want or feel the need to.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test too and everythhign appears to be working to me.

@valadas valadas merged commit 8b3a35c into dnnsoftware:develop Feb 15, 2024
3 checks passed
@donker donker deleted the 20240214fix1 branch October 3, 2024 14:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants