Updated Initialize.cs to show modern dotnet4+ versions #6128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadas
requested changes
Sep 2, 2024
Removed untested line of code, restored extra newline after close brace `}`. Build works again for me locally.
Sorry about that. Fixed and works for me now (local build). |
|
There is still 2:
|
Are you messing with me? I just fixed the opposite above, "SA1513 - Closing brace should be followed by blank line" I tried this in both VS Code and VS 2022. The only way not to get one of the two errors is ... Oh, so both editors are just inserting whitespace up to the indented cursor. I am supposed to know to spot that and fix it? Okay, sorry, lesson learned. Follow the rules even if you can't see the difference. I think this will fix it, at least I get neither error in VS 2022 when I force the blank lines. |
Replaced whitespace with blank lines to avoid SA1028 and SA1513 simultaneously. :)
bdukes
reviewed
Sep 3, 2024
Changed to `return` to match first with releases in descending order
jeremy-farrance
commented
Sep 22, 2024
mitchelsellers
approved these changes
Sep 23, 2024
jeremy-farrance
deleted the
Modernize-to-show-accurate-DotNet4-release-number
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6127
Summary
Quick update so that the .NET Framework version shown (e.g. in the PersonaBar) is accurate up to v4.8.1.
Also updated the code style (no more
else) making it easy to added new versions in the future.Reference: DotNet Versions via Code