Merge pull request #5 from hawkeyexl/next

1.3.1: - Fix for initial settings on extension install - Fix for SVG background colors
doc-detective · Jan 9, 2023 · d83f9de · d83f9de
2 parents fb3265c + 22b38d3
commit d83f9de
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 13 deletions.
diff --git a/src/background-manifestv2.js b/src/background-manifestv2.js
@@ -1,5 +1,12 @@
 var browser = require("webextension-polyfill");
 
+// On extension install/update
+browser.runtime.onInstalled.addListener((details) => {
+  if (details.reason == "install") {
+    setDefaultOptions();
+  }
+});
+
 // On extension button click (Firefox - Manifest v2)
 browser.browserAction.onClicked.addListener((tab) => insertDialog(tab));
 
@@ -43,7 +50,7 @@ async function setDefaultOptions() {
       modeDisallowedIDs: "exact",
       modeDisallowedClasses: "exact",
       modeDisallowedTags: "exact",
-      modeDisallowedAttributes: "exact"
+      modeDisallowedAttributes: "exact",
     });
   }
 }
@@ -52,11 +59,11 @@ function insertDialog(tab) {
   // Inject dialog CSS
   browser.scripting.insertCSS({
     target: { tabId: tab.id },
-    files: ['dialog.css']
+    files: ["dialog.css"],
   });
   // Create or remove dialog
   browser.scripting.executeScript({
     target: { tabId: tab.id },
-    files: ['dialog.js']
+    files: ["dialog.js"],
   });
-}
+}
diff --git a/src/background-manifestv3.js b/src/background-manifestv3.js
@@ -1,7 +1,11 @@
 var browser = require("webextension-polyfill");
 
 // On extension install/update
-browser.runtime.onInstalled.addListener(setDefaultOptions());
+browser.runtime.onInstalled.addListener((details) => {
+  if (details.reason == "install") {
+    setDefaultOptions();
+  }
+});
 
 // On extension button click (Chrome - Manifest v3)
 browser.action.onClicked.addListener((tab) => insertDialog(tab));
@@ -46,7 +50,7 @@ async function setDefaultOptions() {
       modeDisallowedIDs: "exact",
       modeDisallowedClasses: "exact",
       modeDisallowedTags: "exact",
-      modeDisallowedAttributes: "exact"
+      modeDisallowedAttributes: "exact",
     });
   }
 }
@@ -55,11 +59,11 @@ function insertDialog(tab) {
   // Inject dialog CSS
   browser.scripting.insertCSS({
     target: { tabId: tab.id },
-    files: ['dialog.css']
+    files: ["dialog.css"],
   });
   // Create or remove dialog
   browser.scripting.executeScript({
     target: { tabId: tab.id },
-    files: ['dialog.js']
+    files: ["dialog.js"],
   });
-}
+}
diff --git a/src/dialog.css b/src/dialog.css
@@ -51,6 +51,10 @@
   margin: 0 20px 0 8px;
 }
 
+#doc-detective button svg {
+  color: black;
+}
+
 #doc-detective .settings {
   margin: auto 2px auto auto;
   height: 18px;
@@ -60,6 +64,10 @@
   padding: 0;
 }
 
+#doc-detective .settings svg {
+  background-color: white;
+}
+
 #doc-detective .copy {
   position: absolute;
   margin: auto 0;
@@ -70,7 +78,6 @@
   padding: 0;
 }
 
-#doc-detective button svg {
-  color: black;
-  background-color: white;
-}
+#doc-detective .copy svg {
+  background-color: #efefef;
+}