This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
move functions for single element to a separate utility class #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuhanyu
suggested changes
May 18, 2020
| @@ -166,7 +167,7 @@ void addChildren(TypeElement classElement, List<String> children) { | |||
|
|
|||
| List<? extends Element> filterPrivateElements(List<? extends Element> elements) { | |||
| return elements.stream() | |||
| .filter(element -> !ElementUtil.isPrivateOrPackagePrivate(element)).collect(Collectors.toList()); | |||
| .filter(element -> !Utils.isPrivateOrPackagePrivate(element)).collect(Collectors.toList()); | |||
There was a problem hiding this comment.
Naming, be more specified about what util.
There was a problem hiding this comment.
Reused the logic from java standard doclet source code, so followed its' class naming.
Thinking of using another pr to refine the package name (name space) to make utility structure clearer.
killa1218
suggested changes
May 18, 2020
anmeng10101
force-pushed
the
anmeng-moveUtils
branch
2 times, most recently
from
fc697d7
to
788e6fe
Compare
anmeng10101
force-pushed
the
anmeng-moveUtils
branch
from
788e6fe
to
508d546
Compare
wuhanyu
approved these changes
May 18, 2020
| @@ -39,7 +39,7 @@ public SuperHero(String heroName, String uniquePower, int health, int defense) { | |||
| * </p> | |||
| * | |||
| * @param incomingDamage the amount of incoming damage for {@link SuperHero} | |||
| * @param damageType type of damage with similar word damageTypeLong, sure | |||
| * @param damageType type of damage with similar word damageTypeLong, sure | |||
killa1218
approved these changes
May 18, 2020
anmeng10101
added a commit
to anmeng10101/docfx-doclet
that referenced
this pull request
Jun 5, 2020
anmeng10101
added a commit
that referenced
this pull request
Jun 5, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.