This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Treat -1 as default value for memory swappiness #654
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #639 for some older kernels setting swappiness fails. This happens even when nobody tries to configure swappiness from docker UI because we would still get some default value from host config. With this we treat -1 value as default value and skip the enforcement of swappiness. Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
| } else if cgroup.MemorySwappiness == -1 { | ||
| return nil | ||
| } else { | ||
| return fmt.Errorf("Invalid value:%d. Valid memory swappiness range is 0-100", cgroup.MemorySwappiness) |
There was a problem hiding this comment.
nit: Go errors start with lowercase. Here and below.
|
I think you should port this PR to opencontainers/runc/libcontainer. |
ktraghavendra
force-pushed
the
639_container_swappiness
branch
from
8e98d8a to
24063ef
Compare
|
@LK4D4 Thanks, okay will look into opencontainers' porting |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #639 for some older kernels setting swappiness
fails. This happens even when nobody tries to configure swappiness
from docker UI because we would still get some default value from
host config.
With this we treat -1 value as default value and skip the enforcement
of swappiness.
Signed-off-by: Raghavendra K T raghavendra.kt@linux.vnet.ibm.com