-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Mongo Express: Update docs of mongo-express #2401
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CI, our markdownfmt
I think found a case of tabs vs spaces, and I've left a couple suggestions for using the templating to inject the image name (so it works properly on the architecture-specific repos too)
mongo-express/content.md
Outdated
-e ME_CONFIG_OPTIONS_EDITORTHEME="ambiance" \ | ||
-e ME_CONFIG_BASICAUTH_USERNAME="user" \ | ||
-e ME_CONFIG_BASICAUTH_PASSWORD="fairly long password" \ | ||
mongo-express |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mongo-express | |
%%IMAGE%% |
mongo-express/content.md
Outdated
@@ -9,7 +9,7 @@ mongo-express is a web-based MongoDB admin interface written in Node.js, Express | |||
# How to use this image | |||
|
|||
```console | |||
$ docker run --network some-network -e ME_CONFIG_MONGODB_SERVER=some-mongo -p 8081:8081 %%IMAGE%% | |||
$ docker run --link some_mongo_container:mongo -p 8081:8081 -e ME_CONFIG_MONGODB_URL="mongodb://mongo:27017" mongo-express |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ docker run --link some_mongo_container:mongo -p 8081:8081 -e ME_CONFIG_MONGODB_URL="mongodb://mongo:27017" mongo-express | |
$ docker run --link some_mongo_container:mongo -p 8081:8081 -e ME_CONFIG_MONGODB_URL="mongodb://mongo:27017" %%IMAGE%% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, --link
is deprecated and we removed it from most of our docs intentionally; see #1441
mongo-express/content.md
Outdated
-e ME_CONFIG_BASICAUTH_PASSWORD="fairly long password" \ | ||
%%IMAGE%% | ||
--name mongo-express \ | ||
--link web_db_1:mongo \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
You might also appreciate |
Signed-off-by: Bervianto Leo Pratama <bervianto.leo@gmail.com>
Update the mongo-express docs.
Reference:
https://github.com/mongo-express/mongo-express-docker/blob/master/README.md
Related issue:
mongo-express/mongo-express-docker#106