Remove log decoration from workers output

[lcobucci]

As of PHP 7.3 we can finally use STDOUT and STDERR properly in our containers, this disables the [pool %s] child %d said into %s: \"%s\ format.

More info:

• FPM logger refactoring php/php-src#2458
• https://bugs.php.net/bug.php?id=71880
• Logs to stdout get prefixed with warning in php-fpm image #207

[lcobucci]

@yosifkit as far as I saw the build failures are not related to the changes I've made, should I do something here?

[yosifkit]

No, the build is fine. The one problem I see is that these changes will be lost as soon as update.sh is run by jenkins. This will need to be added in the template fpm-Dockerfile-block-2 too and then probably excluded via update.sh in older versions.

Would you like to take that on or would you like me to take over from here?

Also, thanks for the contribution! Glad PHP-FPM now has a setting for this. 😄

[lcobucci]

@yosifkit I feel a bit dumb for not reading the update.sh script before 😂
BTW it's a very helpful script that one 👍

Maybe we could add a simple CONTRIBUTING.md to the repo with some instructions? I can send something tomorrow...

Would you like to take that on or would you like me to take over from here?

I think everything should be fine now but please let me know if there's anything else to change.

Also, thanks for the contribution! Glad PHP-FPM now has a setting for this. smile

My pleasure, I'm also pretty eager to clean up my php-fpm logs 😁

[yosifkit]

LGTM. cc @tianon

We would welcome a helpful contributing.md, if you have the time. (thanks!)

[bukka]

@lcobucci @tianon @yosifkit Nice that this got integrated! I'm the author of these changes in FPM and wanted suggest to also bum the log_limit which was kept on 1024 just for BC reasons but it would make much more sense to have it set at least to 8192 to not wrap some longer lines (e.g. back traces). I'm currently quite busy to create a PR in here but if some one has got more time for it, that would be great! Otherwise will try to find a time in the next couple of weeks.

[wollanup]

@bukka What about 502 errors on nginx because of 2048 log size limit ?

I updated some images from php 7.0 to 7.4, and now with default conf I experience 502 if I want to error_log a $throwable->__toString();

Had to edit /usr/local/etc/php-fpm.d/docker.conf and set something under 2048.

Is this an expected behavior ?

[lunfel]

I use Laravel with a docker-compose setup and when I use the errorlog logging channel (Laravel logging configuration), I get 502 on requests that have exceptions. It seems to be aligned with what @wollanup is saying about throwable.

From nginx I kept having upstream sent too big header while reading response header from upstream.

As soon as I changed the logging channel to something else, it started working again (proper 500 error)