github(summary): build record upload optional #394
Conversation
crazy-max
force-pushed
the
summary-without-upload
branch
2 times, most recently
from
7c001b7 to
2a1a1c9
Compare
crazy-max
requested review from
tonistiigi,
sharonchang1,
dvdksn and
colinhemmings
| // Feedback survey | ||
| sum.addRaw(`<p>`).addRaw(`Find this useful? `).addRaw(addLink('Let us know', 'https://docs.docker.com/feedback/gha-build-summary')).addRaw('</p>'); |
There was a problem hiding this comment.
What if we moved this to the end? The inputs and bake def are collapsed by default, so it should still be visible. There's something odd about having this question appear right before the summary.
There was a problem hiding this comment.
Agreed but needs to consider the table can be quite huge if building many targets with bake like
There was a problem hiding this comment.
Yes, but this one is a bit of a special case, right? Do people tend to build more than ~5 or so targets in a run?
There was a problem hiding this comment.
Yes indeed, WDYT @colinhemmings?
There was a problem hiding this comment.
I would like @sharonchang1 input, but I feel like to help discovery it should be close to the top. Users are likely to expand Inputs and definitions to see what they look like, pushing the link down the page.
There was a problem hiding this comment.
@colinhemmings Agreed, maybe right after the table then? We can look at this as follow-up as well.
There was a problem hiding this comment.
if they expand the sections and look at the summary, would they scroll back up later to give feedback?
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
summary-without-upload
branch
from
2a1a1c9 to
b26af9f
Compare
relates to docker/build-push-action#1151