Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle multi-line secret value #233

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Handle multi-line secret value #233

merged 1 commit into from
Nov 17, 2020

Conversation

crazy-max
Copy link
Member

Closes #210

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #233 (84ec6f9) into master (9c13ff4) will increase coverage by 0.77%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   73.57%   74.34%   +0.77%     
==========================================
  Files           4        4              
  Lines         140      152      +12     
  Branches       24       26       +2     
==========================================
+ Hits          103      113      +10     
  Misses         22       22              
- Partials       15       17       +2     
Impacted Files Coverage Δ
src/buildx.ts 76.00% <66.66%> (-1.09%) ⬇️
src/context.ts 72.72% <86.66%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c13ff4...84ec6f9. Read the comment docs.

@crazy-max crazy-max requested a review from tonistiigi November 17, 2020 18:33
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit eae00c3 into docker:master Nov 17, 2020
@crazy-max crazy-max deleted the secret-multiline branch November 17, 2020 20:47
stephenmsachs added a commit to spack/gitlab-runners that referenced this pull request Dec 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with multi line secrets
3 participants