Refactor the stack services command to be uniform [carry 2131]
#2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
carry_refactor_stack_services
branch
11 times, most recently
from
2d0cd51 to
67be0c7
Compare
4 tasks
thaJeztah
force-pushed
the
carry_refactor_stack_services
branch
from
400ee23 to
4cdc783
Compare
thaJeztah
added
area/kubernetes
area/stack
status/2-code-review
and removed
status/0-triage
labels
Running `docker stack services <STACK> --orchestrator swarm would yield the message "Noting found in stack: asdf" with an exit code 0. The same command with kubernetes orchestrator would yield "nothing found in stack: adsf" (note the lower-case "nothing") and a non-zero exit code. This change makes the `stack services` command uniform for both orchestrators. The logic of getting and printing services is split to reuse the same formatting code. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
carry_refactor_stack_services
branch
from
4cdc783 to
568ea3a
Compare
|
@rumpl @silvin-lubecki @chris-crone PTAL this should be an easy review now |
|
👍 |
thaJeztah
commented
Oct 30, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
carries #2131
closes #2131
depends on:
build static binaries with -tags osusergo #2162 build static binaries with -tags osusergo- What I did
Running
docker stack services <STACK> --orchestrator swarmwould yield the message "Noting found in stack: asdf" with an exit code 0. The same command with kubernetes orchestrator would yield "nothing found in stack: adsf" (note the lower-case "nothing") and a non-zero exit code. This change makes thestack servicescommand uniform for both orchestrators. The logic of getting and printing services is split to reuse the same formatting code.- How to verify it
Run:
Both commands should return
0and show the error messageNoting found in stack: unknown.- Description for the changelog
Stack services will return the same exit code for all orchestrators.
- A picture of a cute animal (not mandatory but encouraged)
