Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update flag description for docker rm -v #2289

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Update flag description for docker rm -v #2289

merged 1 commit into from
Jan 27, 2020

Conversation

thaJeztah
Copy link
Member

fixes #2285

The -v option removes anonymous volume only, and keeps named volumes.

- Description for the changelog

+ Update flag description for `docker rm -v` to clarify the option only removes anonymous (unnamed) volumes.

@thaJeztah
Update flag description for docker rm -v
8f5379b 
The `-v` option removes anonymous volume only, and keeps
named volumes.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@cpuguy83 ptal

cpuguy83
cpuguy83 approved these changes Jan 25, 2020
View reviewed changes
Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chris-crone
chris-crone approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

silvin-lubecki
silvin-lubecki approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 809cc89 into docker:master Jan 27, 2020
@thaJeztah thaJeztah deleted the update_flag_description branch January 27, 2020 14:52
@thaJeztah thaJeztah mentioned this pull request Jan 27, 2020
Merged
@thaJeztah thaJeztah added this to the next milestone Feb 5, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@chris-crone chris-crone chris-crone approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees
No one assigned
Labels
impact/changelog process/cherry-picked status/2-code-review
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.

fix docker container rm -v flag description and docs to mention "anonymous" volumes only
5 participants
@thaJeztah @cpuguy83 @chris-crone @silvin-lubecki @GordonTheTurtle