socket: return from loop after EOF #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4805 +/- ##
=======================================
Coverage 59.63% 59.63%
=======================================
Files 287 287
Lines 24777 24777
=======================================
Hits 14775 14775
Misses 9114 9114
Partials 888 888 |
thaJeztah
added
status/2-code-review
area/plugins
process/cherry-pick
kind/bugfix
This was referenced Jan 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a plugin receives the termination request via socket and closes the context, it atm goes into a tight loop that never returns.