vendor: github.com/docker/docker 5cc3f1dab895 (master, v28.0.0-rc.2) #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: golang/sys@v0.28.0...v0.29.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5825 +/- ##
=======================================
Coverage 59.18% 59.18%
=======================================
Files 352 352
Lines 29547 29547
=======================================
Hits 17486 17486
Misses 11080 11080
Partials 981 981 |
thaJeztah
force-pushed
the
bump_engine
branch
2 times, most recently
from
c1b7df9 to
f9f3ca7
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
bump_engine
branch
from
f9f3ca7 to
cb76c80
Compare
thaJeztah
commented
Feb 14, 2025
Comment on lines
+101
to
104
| // FIXME(thaJeztah): need to find appropriate way to test the result of "ImageHistoryWithPlatform" being applied | ||
| assert.Check(t, len(options) > 0) // can be 1 or two depending on whether a terminal is attached :/ | ||
| // assert.Check(t, is.Contains(options, client.ImageHistoryWithPlatform(ocispec.Platform{OS: "linux", Architecture: "amd64"}))) | ||
| return []image.HistoryResponseItem{{ |
There was a problem hiding this comment.
We should look at better options for testing these; possibly pass in a fake http client to check what request it's making.
full diff: moby/moby@b570831...5cc3f1d Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_engine
branch
from
cb76c80 to
1d3eb6f
Compare
thaJeztah
changed the title
neersighted
approved these changes
Feb 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor: golang.org/x/sys v0.29.0
full diff: golang/sys@v0.28.0...v0.29.0
vendor: github.com/docker/docker 5cc3f1dab895 (master, v28.0.0-rc.2)
full diff: moby/moby@b570831...5cc3f1d
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)