Don't stop pull for images that can be built #10054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Don't immediately stop pulling on failure for image that can be built: Wait for other pullable images to complete.
Only stop with immediate error if some image can't be pulled and has no build config.
Note: this still eventually fails with a !=0 exit code. Maybe we should introduce a new flag to ignore pull failures on buildable services:
docker compose pull --ignore-buildable
, wdyt ?Related issue
close #8724
(not mandatory) A picture of a cute animal, if possible in relation to what you did