ContainerStart must run sequentially for engine to assing distinct ports within configured range #10067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rts within configured range Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportBase: 75.74% // Head: 77.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10067 +/- ##
==========================================
+ Coverage 75.74% 77.02% +1.27%
==========================================
Files 2 2
Lines 235 235
==========================================
+ Hits 178 181 +3
+ Misses 50 48 -2
+ Partials 7 6 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
glours
approved these changes
Dec 12, 2022
|
Is there a solution for compose V3 without adding containerized NGINX, for example? |
|
I am still getting the port mapping error on windows. Here is the version: is it fixed for above version? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
A service configured with
port: 6000-6010:80will get a random port assigned within this rangeAs we invoke
ContainerStart, engine select an available port within container's config port range.If we invoke those concurrently for containers within same service, engine will fail to assign a distinct port.
Arguably, engine should manage concurrent access and prevent this to happen, but .. ¯\(ツ)/
Related issue
fixes #8530
(not mandatory) A picture of a cute animal, if possible in relation to what you did
