Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

apply uid/gid when creating secret from environment #10084

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 15, 2022

What I did

Related issue
relates to #9648 but only applies to secret set from environment variable

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 75.79% // Head: 77.38% // Increases project coverage by +1.58% 🎉

Coverage data is based on head (5c1484e) compared to base (0fedddb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10084      +/-   ##
==========================================
+ Coverage   75.79%   77.38%   +1.58%     
==========================================
  Files           2        2              
  Lines         252      252              
==========================================
+ Hits          191      195       +4     
+ Misses         53       50       -3     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 75.74% <0.00%> (+1.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours enabled auto-merge December 15, 2022 14:54
@glours glours merged commit 0eaa249 into docker:v2 Dec 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants